feat: support 16kb page sizes by mhamann · Pull Request #66 · rownd/react-native

mhamann · 2026-01-15T16:42:30Z

Summary by Sourcery

Update the Android plugin and React Native example app to current tooling and dependencies while wiring the library module into the example app.

Enhancements:

Upgrade the Rownd Android SDK and related Kotlin/serialization dependencies to the latest major versions.
Raise the minimum, target, and compile SDK levels for the library to align with modern Android requirements, including Java 21 compatibility.
Update the React Native example app and tooling (React, React Native, Babel, Metro, RN CLI) to current releases and adjust Metro config to use the new blockList option.
Wire the Rownd React Native project into the example app dependencies and update manifest and SoLoader initialization for the newer React Native architecture.

Build:

Bump Android Gradle plugin, Gradle wrapper, SDK/NDK, and Kotlin versions for both the library and example app.
Adopt the React Native Gradle plugin and settings-based configuration for native modules instead of legacy apply-from scripts.
Increase Gradle JVM memory settings for the example Android project.

sourcery-ai · 2026-01-15T16:42:38Z

Reviewer's Guide

Modernizes the React Native example app and Android plugin configuration to align with React Native 0.76 and newer Android/Kotlin/Gradle tooling, updates the Rownd Android SDK and serialization libs, and wires the example app to consume the local rownd_react-native module.

File-Level Changes

Change	Details	Files
Upgrade React Native example app and tooling to 0.76 ecosystem and new CLI/plugin-based autolinking.	Bump react and react-native versions in example package.json and align @react-native/* dev tooling packages to 0.76.x. Add @react-native-community/cli packages and move Metro config to use resolver.blockList instead of blacklistRE. Replace native_modules.gradle usage with the new @react-native/gradle-plugin and com.facebook.react.settings plugin in example/android settings.gradle and app/build.gradle. Introduce yarn.lock for dependency locking in the example app.	`example/package.json` `example/metro.config.js` `example/android/settings.gradle` `example/android/app/build.gradle` `example/yarn.lock`
Modernize Android build configuration for the example app to current Gradle, Android, and Kotlin plugin versions.	Update Android Gradle Plugin to 8.6.0 and Gradle wrapper to 8.10.2. Switch example/android/build.gradle from buildscript/apply plugin to plugins DSL and bump build tools, compile/target SDK, NDK, and Kotlin versions. Increase Gradle JVM memory settings in example/android/gradle.properties. Set an explicit package name in the example Android manifest and update SoLoader initialization to use OpenSourceMergedSoMapping for RN 0.76.	`example/android/build.gradle` `example/android/gradle/wrapper/gradle-wrapper.properties` `example/android/gradle.properties` `example/android/app/src/main/AndroidManifest.xml` `example/android/app/src/main/java/com/awesomemoduleexample/MainApplication.kt`
Update library Android module to target newer Android/Kotlin toolchains and latest Rownd Android SDK.	Raise plugin-level min/target/compile SDK, Kotlin, and NDK versions in android/gradle.properties to modern values compatible with 16KB pages. Set Java source/target compatibility to Java 21 in android/build.gradle. Upgrade Rownd Android SDK dependency to 4.0.0 and kotlinx-serialization-json to 1.8.0. Remove unused imports from RowndPluginModule and RowndPluginPackage.	`android/gradle.properties` `android/build.gradle` `android/src/main/java/com/reactnativerowndplugin/RowndPluginModule.kt` `android/src/main/java/com/reactnativerowndplugin/RowndPluginPackage.kt`
Wire the example Android app to consume the local rownd_react-native library module instead of legacy autolinking.	Add implementation project(":rownd_react-native") dependency to example app module. Remove legacy applyNativeModulesAppBuildGradle native_modules.gradle hook from example/android/app/build.gradle. Remove old CLI/native module settings include from example/android/settings.gradle in favor of React Native Gradle Plugin configuration.	`example/android/app/build.gradle` `example/android/settings.gradle`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've found 1 issue, and left some high level feedback:

Raising sourceCompatibility/targetCompatibility to Java 21 in android/build.gradle is a big jump relative to typical React Native Android baselines; consider whether Java 17 (or matching the minimum required by AGP/RN) would be safer for consumers of this library.
The example app and the library Gradle properties now use different SDK levels (example targets/compiles 35 while RowndPlugin_targetSdkVersion is 34); it may be worth aligning these to avoid subtle behavior differences between the example and consuming apps.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Raising `sourceCompatibility`/`targetCompatibility` to Java 21 in `android/build.gradle` is a big jump relative to typical React Native Android baselines; consider whether Java 17 (or matching the minimum required by AGP/RN) would be safer for consumers of this library.
- The example app and the library Gradle properties now use different SDK levels (example targets/compiles 35 while `RowndPlugin_targetSdkVersion` is 34); it may be worth aligning these to avoid subtle behavior differences between the example and consuming apps.

## Individual Comments

### Comment 1
<location> `android/gradle.properties:3` </location>
<code_context>
-RowndPlugin_ndkversion=21.4.7075529
+RowndPlugin_kotlinVersion=2.0.21
+RowndPlugin_minSdkVersion=26
+RowndPlugin_targetSdkVersion=34
+RowndPlugin_compileSdkVersion=35
+RowndPlugin_ndkversion=26.1.10909125
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Plugin targetSdkVersion is behind the example app’s targetSdkVersion.

The example project now targets SDK 35 while `RowndPlugin_targetSdkVersion` is still 34. Please update this to 35 so the plugin is validated against the same (latest) target SDK as the host app and to reduce the risk of behavioral differences.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

sourcery-ai

New security issues found

sourcery-ai

New security issues found

The exclusionList function moved from a named export in metro-config to a default export at metro-config/src/defaults/exclusionList in newer Metro versions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

feat: support 16kb page sizes

b248e73

Merge remote-tracking branch 'origin/main' into feat-android-upgrade

7723e91

sourcery-ai Bot reviewed Jan 15, 2026

View reviewed changes

Comment thread android/gradle.properties Outdated

chore: github test workflows

325e976

mhamann mentioned this pull request Jan 15, 2026

16kb page size rownd/android#67

Closed

mhamann added 6 commits January 15, 2026 12:00

chore: linting

d614b57

chore: linting

e038831

chore: upgrade expo example

8d56a6d

chore: test suite fixups

ab0c6ea

chore: expo build fixes

3b39daf

chore: ios pod bumps

d624695

sourcery-ai Bot reviewed Jan 15, 2026

View reviewed changes

Comment thread example/ios/Podfile.lock

mhamann added 2 commits January 15, 2026 12:54

chore: resolve some versioning mismatches

d6682cd

fix: expo ios example

f391746

sourcery-ai Bot reviewed Jan 15, 2026

View reviewed changes

Comment thread example_expo/ios/Podfile.lock

Comment thread example_expo/ios/Podfile.lock

Comment thread example_expo/ios/Podfile.lock

mhamann and others added 3 commits January 15, 2026 14:25

fix: update exclusionList import for Metro compatibility

1aef555

The exclusionList function moved from a named export in metro-config to a default export at metro-config/src/defaults/exclusionList in newer Metro versions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

chore: update to latest android lib version

f03d78d

chore: fix android package ref

bbda356

mhamann merged commit 3da64f8 into main Jan 20, 2026
6 of 7 checks passed

mhamann deleted the feat-android-upgrade branch January 20, 2026 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support 16kb page sizes#66

feat: support 16kb page sizes#66
mhamann merged 14 commits into
mainfrom
feat-android-upgrade

mhamann commented Jan 15, 2026 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot commented Jan 15, 2026 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

mhamann commented Jan 15, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mhamann commented Jan 15, 2026 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Jan 15, 2026 •

edited

Loading